Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: azurerm_scheduler_job_collection #990

Merged
merged 4 commits into from
Mar 22, 2018

Conversation

katbyte
Copy link
Collaborator

@katbyte katbyte commented Mar 16, 2018

No description provided.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments to address - but this otherwise LGTM providing the tests pass 👍

}

d.SetId(*collection.ID)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we set the other fields here? e.g. location, resource_group_name, name etc


* `max_job_count` - Sets the maximum number of jobs in the collection.

* `max_recurrence_frequency` - The maximum frequency of recurrence. Possible values include: `Minute`, `Hour`, `Day`, `Week`, `Month`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be able to remove the Possible values... from this section - since these values will be being returned


* `tags` - A mapping of tags to assign to the resource.

* `sku` - The Job Collection's pricing level's SKU. Possible values include: `Standard`, `Free`, `P10Premium`, `P20Premium`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should be able to remove the Possible values... from this section - since these values will be being returned

page_title: "Azure Resource Manager: azurerm_scheduler_job_collection"
sidebar_current: "docs-azurerm-datasource-scheduler_job_collection"
description: |-
Get information about the specified schelduer job collection.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scheduler*


* `name` - (Required) Specifies the name of the Scheduler Job Collection. Changing this forces a new resource to be created.

* `resource_group_name` - (Required) The name of the resource group in which to create the Scheduler Job Collection. Changing this forces a new resource to be created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not creating anything - so we can we change this to Specifies the name of the Resource Group in which the Scheduler Job Collection exists


The following arguments are supported:

* `name` - (Required) Specifies the name of the Scheduler Job Collection. Changing this forces a new resource to be created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not creating anything - so we can we change this to Specifies the name of the Scheduler Job Collection

@katbyte katbyte force-pushed the f-ds-scheduler_job_collection branch from 5977c3e to 6ad99fc Compare March 19, 2018 07:32
@katbyte
Copy link
Collaborator Author

katbyte commented Mar 21, 2018

Tests pass:
screen shot 2018-03-20 at 20 33 31

@tombuildsstuff tombuildsstuff changed the title Added new data source scheduler_job_collection New Data Source: azurerm_scheduler_job_collection Mar 22, 2018
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff merged commit c253114 into master Mar 22, 2018
@tombuildsstuff tombuildsstuff deleted the f-ds-scheduler_job_collection branch March 22, 2018 14:43
tombuildsstuff added a commit that referenced this pull request Mar 22, 2018
@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants